Zeitpunkt Nutzer Delta Tröts TNR Titel Version maxTL Mo 07.10.2024 00:01:24 4.818 +2 283.547 58,9 PHP Community on Mastodon 4.2.13 500 So 06.10.2024 00:01:09 4.816 +1 283.337 58,8 PHP Community on Mastodon 4.2.13 500 Sa 05.10.2024 00:05:30 4.815 +4 283.037 58,8 PHP Community on Mastodon 4.2.13 500 Fr 04.10.2024 00:01:12 4.811 +2 282.682 58,8 PHP Community on Mastodon 4.2.13 500 Do 03.10.2024 00:00:31 4.809 +3 282.297 58,7 PHP Community on Mastodon 4.2.13 500 Mi 02.10.2024 00:02:59 4.806 +4 281.871 58,6 PHP Community on Mastodon 4.2.13 500 Di 01.10.2024 00:01:17 4.802 +6 281.562 58,6 PHP Community on Mastodon 4.2.13 500 Mo 30.09.2024 00:01:15 4.796 0 281.164 58,6 PHP Community on Mastodon 4.2.12 500 So 29.09.2024 00:01:25 4.796 +1 280.940 58,6 PHP Community on Mastodon 4.2.12 500 Sa 28.09.2024 00:01:10 4.795 0 280.625 58,5 PHP Community on Mastodon 4.2.12 500
Skoop (Stefan Koopmanschap) (@Skoop) · 08/2018 · Tröts: 3.623 · Folger: 1.345
Mo 07.10.2024 13:54
This morning I created a simple bugfix PR.
I made a small mistake. Missed an exclamation mark in an if statement which should've been removed.
My colleague found it, commented on it during the review, which allowed me to fixed it.
This is proof of two things:
- We should ALWAYS do code reviews, have another set of eyes looking at changes
- We should NOT use `!` for checks. Always explicitly check for values with `=== false`
[Öffentlich] Antw.: 0 Wtrl.: 0 Fav.: 0